chromium/chromium-exclude_unwind_tables.patch

   1 From 1fc37227522ccd314f82ec893ed15c6129296604 Mon Sep 17 00:00:00 2001
   2 From: Paul Jensen <pauljensen@chromium.org>
   3 Date: Wed, 11 Oct 2017 08:37:34 -0400
   4 Subject: [PATCH] Move exclude_unwind_tables back into declare_args
   5
   6 There is desire to adjust this flag manually.
   7
   8 BUG=762629
   9 R=thakis@chromium.org
  10
  11 Change-Id: I3bd134c19270cd1f729b3ea078674e734493d4ab
  12 ---
  13
  14 diff --git a/build/config/compiler/compiler.gni b/build/config/compiler/compiler.gni
  15 index ad40fd9..50e19a4 100644
  16 --- a/build/config/compiler/compiler.gni
  17 +++ b/build/config/compiler/compiler.gni
  18 @@ -68,18 +68,18 @@
  19
  20    # Whether or not we should use position independent code.
  21    use_pic = true
  22 +
  23 +  # Exclude unwind tables for official builds as unwinding can be done from
  24 +  # stack dumps produced by Crashpad at a later time "offline" in the crash
  25 +  # server. For unofficial (e.g. development) builds and non-Chrome branded
  26 +  # (e.g. Cronet which doesn't use Crashpad, crbug.com/479283) builds it's
  27 +  # useful to be able to unwind at runtime.
  28 +  exclude_unwind_tables = (is_chrome_branded && is_official_build) ||
  29 +                          (is_chromecast && !is_cast_desktop_build && !is_debug)
  30  }
  31
  32  assert(!is_cfi || use_thin_lto, "CFI requires ThinLTO")
  33
  34 -# Exclude unwind tables for official builds as unwinding can be done from stack
  35 -# dumps produced by Crashpad at a later time "offline" in the crash server.
  36 -# For unofficial (e.g. development) builds and non-Chrome branded (e.g. Cronet
  37 -# which doesn't use Crashpad, crbug.com/479283) builds it's useful to be able
  38 -# to unwind at runtime.
  39 -exclude_unwind_tables = (is_chrome_branded && is_official_build) ||
  40 -                        (is_chromecast && !is_cast_desktop_build && !is_debug)
  41 -
  42  # If true, optimize for size. Does not affect windows builds.
  43  # Linux & Mac favor speed over size.
  44  # TODO(brettw) it's weird that Mac and desktop Linux are different. We should